Skip to content

Conversation

@nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Jan 28, 2026

this is required because we ingest as f64
with i64, the type casting fails

Summary by CodeRabbit

  • Refactor
    • Improved internal precision handling for statistics calculations to support more accurate data analysis.

✏️ Tip: You can customize this high-level summary in your review settings.

this is required because we ingest as f64
with i64, the type casting fails
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Walkthrough

Changes integer count types to floating-point types in two public structs (FieldStats and QueryRow) within the field statistics module, affecting how counts are represented and stored.

Changes

Cohort / File(s) Summary
Type conversion in field statistics
src/storage/field_stats.rs
Changed count fields from i64 to f64 in FieldStats struct (field_count, distinct_count, and values in distinct_values map) and QueryRow struct (field_count, distinct_count, distinct_value_count)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 From whole counts to decimal precision,
The fields now measure with more decision,
Where integers once bounded tight,
Floats now dance in measured light,
More nuance in each statistic's sight! 📊

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required sections from the template (Fixes #XXXX, goal description, key changes, and testing checklist) and is overly brief. Include the issue number, detailed description of the goal and rationale, key changes made, and complete the provided checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating datatypes in FieldStats and QueryRow from i64 to f64.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitisht nitisht merged commit ac05480 into parseablehq:main Jan 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants