refactor: remove unnecessary clones when constructing notes#3
Open
VolodymyrBg wants to merge 2 commits intopartylikeits1983:mainfrom
Open
refactor: remove unnecessary clones when constructing notes#3VolodymyrBg wants to merge 2 commits intopartylikeits1983:mainfrom
VolodymyrBg wants to merge 2 commits intopartylikeits1983:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed redundant clone calls when building NoteRecipient and Note in the swap and notes helpers. Now pass ownership of NoteScript, NoteInputs and NoteAssets directly into NoteRecipient::new and Note::new, avoiding extra allocations and copies. The behavior of note creation remains unchanged, but the implementation is leaner and consistent with other note helpers in the codebase.