fix: require click to activate scroll-to-adjust on sliders#182
Open
nnhhoang wants to merge 1 commit intopascalorg:mainfrom
Open
fix: require click to activate scroll-to-adjust on sliders#182nnhhoang wants to merge 1 commit intopascalorg:mainfrom
nnhhoang wants to merge 1 commit intopascalorg:mainfrom
Conversation
Previously, hovering over any SliderControl would hijack the scroll wheel, causing unintentional value changes when scrolling through property panels (e.g. door, window). Now the slider must be clicked to focus before scroll adjusts its value. Click outside or press Escape to unfocus. Closes pascalorg#161
nnhhoang
force-pushed
the
fix/slider-scroll-ux
branch
from
1f14498 to
3da25b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #161
Screenshots
Unfocused sliders (default state — scroll passes through normally)
Focused slider (after click — scroll adjusts value, highlighted border)
Steps to reproduce
Select door/window/wall → open property panel → scroll through sliders
Before (bug): hover over slider → scroll → value changes unintentionally
After (fix): hover over slider → scroll → panel scrolls normally → click slider → slider gets focus border → scroll → value changes → click outside / press Escape → slider unfocused → scroll passes through again
Test plan