fix: implement T key for counter-clockwise rotation on selected nodes#184
Open
nnhhoang wants to merge 1 commit intopascalorg:mainfrom
Open
fix: implement T key for counter-clockwise rotation on selected nodes#184nnhhoang wants to merge 1 commit intopascalorg:mainfrom
nnhhoang wants to merge 1 commit intopascalorg:mainfrom
Conversation
The keyboard shortcuts dialog documents T as counter-clockwise rotation, and it works during placement/move mode, but was missing for already selected nodes. R (clockwise) worked in all contexts but T did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tas "Rotate item counter-clockwise by 90 degrees"Talready works during placement/move mode (use-placement-coordinator.tsx,move-roof-tool.tsx)Ton an already selected node did nothing — onlyR(clockwise) workedThandler inuse-keyboard.tsmatching the existingRhandler patternSteps to reproduce (before fix)
Select item/door/window → press
R→ rotates clockwise → pressT→ nothing happensAfter fix
Select item/door/window → press
R→ rotates clockwise → pressT→ rotates counter-clockwiseTest plan