fix: address issues #153-#156 (App wf fallback, e2e hardening, ruleset strict=false, test additions)#157
Merged
Merged
Conversation
- Add label-based release guard step in auto-approve.yml (autorelease: pending) - New scripts/guard-no-release-merge.sh hard-fail script for agents/humans - Document 'Release PRs - Strong Guard' procedure + ask_user_question requirement in AGENTS.md - Update tracking in patchloom-vscode-contrib skill (local only) Prevents recurrence of agent running gh pr merge --auto on release-please PRs without explicit user yes. All changes pass npm run check (259 tests, package ok). Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
…et strict=false, coverage tests) - #153: auto-approve now falls back to GITHUB_TOKEN for auto-merge on wf-touching PRs (conditional App token creation); removes hard dependency on workflows:write grant. - #154: added normalize/CRLF test case exercising pure helper in initializeProject. - #155: bumped e2e managed/MCP timeouts to 60s for cold-start robustness. - #156: updated live ruleset strict_required_status_checks_policy=false; release PRs now merge reliably when green. Closes #153 Closes #154 Closes #155 Closes #156 All via npm run check (clean), double-checked, subagent reviewer passed (mostly ready, followed suggestions for full gate + draft PR flow). Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
changed the title
…h for #154) Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch fix for open issues #153 and up (tech debt from anti-rationalization audit after #147+ and strong guard work).
Changes
GITHUB_TOKENfor--auto --squashon workflow-touching PRs. Removes hard GraphQL blocker. (Grant still recommended for App token consistency.)normalizeForComparison/ CRLF+ws cases in initializeProject (pure helper coverage).main-branch-protectionruleset (strict_required_status_checks_policy: false). Release (and other) PRs now merge when checks are green without strict staleness blocking.patchloom-vscode-contrib/SKILL.mdand reinforced branch/PR discipline inAGENTS.md.Verification
npm run check(compile + unit tests + coverage gate + package) green multiple times.gh api.Closes #153
Closes #154
Closes #155
Closes #156
Checklist
npm run checkpassesThis PR itself touches workflow file; auto-merge enabled via fallback path (as designed).