Skip to content

docs: clarify that auto-approve self-mod bypass is no longer needed after #160 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SebTardif merged 1 commit into from
Jun 22, 2026
Merged

docs: clarify that auto-approve self-mod bypass is no longer needed after #160 #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,14 @@ All I/O-dependent functions accept an `inputs` object with injectable callbacks
backed by an open (draft) PR from the start. See `~/.grok/skills/owned-repo-gate/SKILL.md`.

- **Auto-approve self-modification:** PRs that change `.github/workflows/auto-approve.yml`
cause GitHub to emit only "push" validation runs (0 jobs, failure) using the PR's workflow content
(the pull_request runs use the definition from main). The approve step runs early using
GITHUB_TOKEN (before wf-changes detection or merge logic) so reviews are added when the
pull_request workflow runs from main. The Enable auto-merge step uses `|| echo` so the
workflow reports success even when merge enable falls back or is restricted. In rare cases
where no review appears, use the emergency bypass in ci-branch-protection skill + #159
(add bypass actor, `gh pr merge --admin`, remove bypass immediately). See also patchloom's
auto-approve.yml for the reference pattern.
still cause GitHub to emit "push" validation runs (0 jobs, failure) using the PR's workflow content
(pull_request runs always use the definition from main). However, the approve step now runs
early using GITHUB_TOKEN, and the Enable auto-merge step uses `|| echo` (plus a hardened
wf-changes check), so the review is submitted and the workflow run reports success.
The specific "stuck in REVIEW_REQUIRED with no bot review" case that required the bypass
for auto-approve self-mods (see historical #157 / #159) is resolved. The general emergency
hatch in ci-branch-protection remains available for other auto-approve outages. See
patchloom's auto-approve.yml for the reference pattern.

## Release PRs - Strong Guard

Expand Down
Loading