fix: bump minimum supported CLI version to 0.3.0#167
Merged
Conversation
The extension uses `append` (added in v0.3.0) and `patch merge` (added in v0.2.0), so 0.1.0 was never a correct minimum. Users on 0.1.x or 0.2.x would see CLI errors for Append and Merge Patch quick actions. Update MINIMUM_SUPPORTED_PATCHLOOM_VERSION and all references. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| assert.match(details, /Detected CLI version: 0\.0\.9/); | ||
| assert.match(details, /Required CLI version: >= 0\.1\.0/); | ||
| assert.match(details, new RegExp(`Required CLI version: >= ${MINIMUM_SUPPORTED_PATCHLOOM_VERSION.replace(/\./g, "\\.")}`)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension uses
append(added in v0.3.0) andpatch merge(added in v0.2.0), so 0.1.0 was never a correct minimum. Users on 0.1.x or 0.2.x would see CLI errors for the Append to File and Merge Patch quick actions.Changes
MINIMUM_SUPPORTED_PATCHLOOM_VERSION:0.1.0->0.3.0