Include tests and useful/related test files in sdist #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for downstream users, including OS packagers to QA/test if the package works correctly without requiring fetching the sources from the repository.
Contributor
Author
|
I note this is a duplicate of #57, apologies |
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Dec 18, 2019
While we prefer using CHEESESHOP when souces are provided there, in the event it's missing valuable files such as tests, test data, LICENCE, it is preferable and more robust to use an alternative source entirely, than a combination of CHEESESHOP (or anything else) combined with another source for specific files, which can cause issues [1] This change switches to USE_GITHUB and removes unecessary and associated Makefile entries accordingly. [1] ports r516897 See Also: patrys/httmock#59 PR: 242694 Submitted by: Derek Schrock <dereks lifeofadishwasher com> MFH: 2019Q4 (blanket: fetch/build fix) MFH-With: r516897 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@520357 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 18, 2019
While we prefer using CHEESESHOP when souces are provided there, in the event it's missing valuable files such as tests, test data, LICENCE, it is preferable and more robust to use an alternative source entirely, than a combination of CHEESESHOP (or anything else) combined with another source for specific files, which can cause issues [1] This change switches to USE_GITHUB and removes unecessary and associated Makefile entries accordingly. [1] ports r516897 See Also: patrys/httmock#59 PR: 242694 Submitted by: Derek Schrock <dereks lifeofadishwasher com> MFH: 2019Q4 (blanket: fetch/build fix) MFH-With: r516897 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@520357 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 18, 2019
While we prefer using CHEESESHOP when souces are provided there, in the event it's missing valuable files such as tests, test data, LICENCE, it is preferable and more robust to use an alternative source entirely, than a combination of CHEESESHOP (or anything else) combined with another source for specific files, which can cause issues [1] This change switches to USE_GITHUB and removes unecessary and associated Makefile entries accordingly. [1] ports r516897 See Also: patrys/httmock#59 PR: 242694 Submitted by: Derek Schrock <dereks lifeofadishwasher com> MFH: 2019Q4 (blanket: fetch/build fix) MFH-With: r516897
Owner
|
@koobs I think the same point stands, unless we make it a package, the extra files could potentially collide with files shipped by another package. |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 20, 2019
While we prefer using CHEESESHOP when souces are provided there, in the event it's missing valuable files such as tests, test data, LICENCE, it is preferable and more robust to use an alternative source entirely, than a combination of CHEESESHOP (or anything else) combined with another source for specific files, which can cause issues [1] This change switches to USE_GITHUB and removes unecessary and associated Makefile entries accordingly. [1] ports r516897 See Also: patrys/httmock#59 PR: 242694 Submitted by: Derek Schrock <dereks lifeofadishwasher com> Approved by: ports-secteam (blanket: fetch/build fix)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 1, 2021
While we prefer using CHEESESHOP when souces are provided there, in the event it's missing valuable files such as tests, test data, LICENCE, it is preferable and more robust to use an alternative source entirely, than a combination of CHEESESHOP (or anything else) combined with another source for specific files, which can cause issues [1] This change switches to USE_GITHUB and removes unecessary and associated Makefile entries accordingly. [1] ports r516897 See Also: patrys/httmock#59 PR: 242694 Submitted by: Derek Schrock <dereks lifeofadishwasher com> Approved by: ports-secteam (blanket: fetch/build fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for downstream users, including OS packagers to QA/test if the package works correctly without requiring fetching the sources from the repository.
Identified by: FreeBSD Ports Bug 242694
Closes: #55