chore: migrate to PatternFly v6#28
Draft
rrosatti wants to merge 7 commits into
Draft
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- labelIcon → labelHelp on FormGroup - Text → Content component - Card: remove isFlat prop - PageSection: variant="light" → hasBodyWrapper - SCSS: pf-v5 class prefixes → pf-v6, CSS vars → pf-t tokens Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace deprecated Select/SelectVariant/SelectOption with the PF v6 composable API: Select, SelectList, SelectOption, MenuToggle with TextInputGroup for typeahead. Remove lodash-es/pull dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace deprecated WizardToggle/WizardNav/WizardNavItem/WizardProps with PF v6 composable equivalents. Map FormikWizardStep to WizardStepType. Replace deprecated WizardFooter with WizardFooterWrapper in stories. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pass shouldValidate=false to setFieldTouched so it does not trigger validation before setFieldValue's state update commits. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix yarn lint errors.
Bump formik-pf version to 0.0.1-alpha12.
Author
|
@sahil143 could you please review this one once you get the chance? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes https://redhat.atlassian.net/browse/KFLUXUI-1393
Description
Migrate formik-pf from PatternFly v5 to v6.
Changes
@patternfly/react-corefrom^5.3.3to^6.5.1SelectFieldto PF v6 composable Select APIFormikWizardto PF v6 composable Wizard APIRadioGroupField- validation no longer fires on first selectionVisual references
Storybook - all components working
formik-pf-migrate-to-v6-storybook.mp4
konflux-ui - components in use
konflux-ui-testing-formik-pf-updated-locally.mov
Test plan