Skip to content

Conversation

@bennypowers
Copy link
Member

@bennypowers bennypowers commented Jun 20, 2024

What I did

  1. add elements to tools
  2. add pft-element-knobs
  3. add knobs demos to dev server

Testing Instructions

  1. run the dev server
  2. http://localhost:8000/
  3. click on knobs

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 1d886fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review functionality Functionality, typically pertaining to the JavaScript. tools Development and build tools labels Jun 20, 2024
@netlify
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 96622b4
😎 Deploy Preview https://deploy-preview-2781--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jun 20, 2024
@github-actions github-actions bot added demo Updating demo pages doc generator Updates relating to the generator styles An issue or PR pertaining only to CSS/Sass tests Related to testing labels Jun 25, 2024
@github-actions
Copy link
Contributor

SSR Test Run for ad7b36d: Report

@github-actions
Copy link
Contributor

SSR Test Run for 80c0e66: Report

@github-actions
Copy link
Contributor

SSR Test Run for f6d3db3: Report

@zeroedin
Copy link
Contributor

@bennypowers this is great! Thinking about picking up pf-drawer to support this. My thinking is maybe the knobs could be out of the way on initial load then toggleable via a drawer. Thoughts?

@bennypowers
Copy link
Member Author

There can be quite a lot of content, more than a side drawer

See text-input for example

Maybe a bottom panel

@zeroedin
Copy link
Contributor

Maybe a bottom panel

Yeah I also noted the resizable drawer too which might be nice on certain viewport sizes.

@bennypowers bennypowers changed the base branch from main to staging/4.0 July 14, 2024 12:42
@github-actions github-actions bot removed doc styles An issue or PR pertaining only to CSS/Sass tests Related to testing generator Updates relating to the generator labels Jul 14, 2024
@github-actions
Copy link
Contributor

SSR Test Run for e181d72: Report

Base automatically changed from staging/4.0 to main August 16, 2024 12:22
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat(tools): knobs"
}

@netlify
Copy link

netlify bot commented May 18, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 1d886fa
🔍 Latest deploy log https://app.netlify.com/projects/patternfly-elements/deploys/682973ae295ac3000846790c
😎 Deploy Preview https://deploy-preview-2781--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

SSR Test Run for 96622b4: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. tools Development and build tools work in progress POC / Not ready for review

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants