Skip to content

Conversation

@dali327519294
Copy link

What I did

  1. Created a new custom element using LitElement.

  2. Implemented a status property with options: 'default', 'success', 'warning', 'error', 'indeterminate'.

  3. Added support for custom icons via icon and icon-set properties.

  4. Added a slot named "icon" for overriding the default icon with a custom SVG.

  5. Added a default slot for the text content.

  6. Styled the element so that the text and icon colors correspond to the status.

Testing Instructions

  1. Import the element in a demo page:
<script type="module"> import '@patternfly/elements/pf-icon/pf-icon.js'; import '@patternfly/elements/pf-helper-text/pf-helper-text.js'; </script>
  1. Add elements with different statuses and icons:
Default helper text Warning helper text Success helper text
  1. Verify that:

The text appears correctly.

The icon matches the status or the custom icon if provided.

The slot "icon" can be overridden with a custom SVG.

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: 1445eef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dali327519294 dali327519294 reopened this Oct 21, 2025
@dali327519294 dali327519294 changed the title feat: create pf-helper-text element feat: create pf-helper-text element[DRAFT] Oct 21, 2025
@bennypowers bennypowers marked this pull request as draft October 22, 2025 06:32
@bennypowers bennypowers changed the title feat: create pf-helper-text element[DRAFT] feat(helper-text): add pf-helper-text element Oct 22, 2025
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants