feat: allow full-page example utils to change position #4896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying patternfly-org with
|
| Latest commit: |
adcd7ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba0330f2.patternfly-org.pages.dev |
| Branch Preview URL: | https://full-page-utils-position.patternfly-org.pages.dev |
Collaborator
mcoker
force-pushed
the
full-page-utils-position
branch
from
39db2d3 to
adcd7ff
Compare
Contributor
Author
|
@bekah-stephens whenever you get a sec, updated to put the buttons in the padding like we discussed. Also changed the icon for the current position so it's a little more obvious. wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4892
Preview - can be seen on any full page example:
https://pf-org--pr-4896-site.surge.sh/ai/generative-uis/compass/html-demos/card-view/
This adds something pretty simple. Not sure how to add this without it taking up the entire switcher. Seems like maybe we need a label or something? Not sure - @bekah-stephens wdyt?