CarouselViewChallenge LifesavingRules#28
Open
kallisto08 wants to merge 1 commit intopauldipietro:masterfrom
Open
CarouselViewChallenge LifesavingRules#28kallisto08 wants to merge 1 commit intopauldipietro:masterfrom
kallisto08 wants to merge 1 commit intopauldipietro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission description
I chose an app that we developed for our company, a screen which displays a list of Lifesaving Rules. I've previously used a Carousel View plugin for a few different areas in the app but thought this would suit this challenge best.
Original Version

Carousel Version

What went well
Really easy to use and super quick to implement.
I love the PeekAreaInsets, makes it really obvious without the page indicators for users that there is something to swipe to.
What didn't go well
I mainly used android for this implementation and it went pretty smoothly. Only a small performance issue to note was a slight delay on loading when a largish image was used.
Missing or desired things
Page indicators would be handy when not using the PeekAreaInsets.
Anything else
Any free swag would be amazing!
Take out a survey for some goodies
Please visit this link to take a survey. If you provide your contact information, we'll send you some swag!