Skip to content

Out of date domain list data (was: Version in gemspec wrong)#17

Open
jamiecobbett wants to merge 2 commits intopauldix:masterfrom
jamiecobbett:master
Open

Out of date domain list data (was: Version in gemspec wrong)#17
jamiecobbett wants to merge 2 commits intopauldix:masterfrom
jamiecobbett:master

Conversation

@jamiecobbett
Copy link
Copy Markdown

It says 0.0.9, but I think it should be 0.0.10.

This prevented me from fully using Bundler's git option.

@larsklevan
Copy link
Copy Markdown

+1 for this - the domain list data being out of data is preventing correct parsing of top level domains like .do

@wireframe
Copy link
Copy Markdown

another +1 for this.

we actually just ran into a similar issue with an out of date domain list.

@coreyward
Copy link
Copy Markdown

+1 — Can we get this pulled in, pretty please?

@danielnc
Copy link
Copy Markdown

+1

@6
Copy link
Copy Markdown

6 commented Sep 21, 2012

As a temporary workaround for supporting newer TLDs, you can use:

d = Domainatrix::DomainParser.new("path/to/updated_effective_tld_names.dat")
d.parse("http://abc.do")
# => {:public_suffix=>"do", :domain=>"abc", :subdomain=>"", :scheme=>"http", :host=>"abc.do", :path=>"", :url=>"http://abc.do"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants