feat: add implementation for haversine distance for geo-coordinates#69
feat: add implementation for haversine distance for geo-coordinates#69sumsamvoi wants to merge 4 commits intopaulmach:masterfrom
Conversation
|
Thank you, but this is already implemented in the For the "distance from" stuff. I'm not sure that's accurate for points+lines on a sphere. I would have to think about but I assume you'd need some more trig functions in there. |
Thank you for the comment. Basically, my use case here was the On your point about how accurate that is, from the benchmark testing I did, it is almost identical to what |
|
@paulmach Made some changes to this, moved all the geo calculations in the geo package and started using the existing "DistanceHaversine" function for calculating the distance between points on earth. Please give further directions of what needs to done to move forward with this. |
In this PR, I have added the implementation for calculating haversine distance between geo coordinates in kilometers. This is useful if you are working with latitude and longitudes. The original implementation only calculates euclidean distances.