Open
Conversation
arminsabouri
commented
Mar 5, 2026
Collaborator
Author
|
Latest changes include
|
Shifted action evaluation from utility maximization to cost minimization inverted outcome scoring. Switched wallet selection to `min_by_key` to pick the lowest cost. Additionally, Mp Payjoin actions should have 0 cost. This is test scaffolding for now and a WIP.
Base cost = amount handled + fee_paid
This strategy will always prefer to consolidate their UTXOs for each payment. This is their most prefered action at 0 cost.
arminsabouri
commented
Mar 6, 2026
Comment on lines
+39
to
+40
| /// Weight applied to UTXO consolidation utility | ||
| pub consolidation_weight: f64, |
Collaborator
Author
There was a problem hiding this comment.
Note this is not used. Probably best to remove it for now
arminsabouri
commented
Mar 6, 2026
| new_multi_party_payjoins: Vec<(BulletinBoardId, MessageId)>, | ||
| current_timestep: TimeStep, | ||
| wallet_id: WalletId, | ||
| spendable_utxos_count: usize, |
Collaborator
Author
There was a problem hiding this comment.
Also did not end up being used since consolidating is represented as a 0 cost action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shifted action evaluation from utility maximization to cost minimization inverted outcome scoring.
Switched wallet selection to
min_by_keyto pick the lowest cost.