Draft
Conversation
Collaborator
Depends on the payjoin status I suppose. If as the sender, we just singed the psbt we should have an option to send as a normal or pj. Any other status should have an option to send as a fallback tx. |
Author
|
Should we take away the logic that sends the payjoin on the looper? With that logic still there a button to do it seems redundant |
Collaborator
Ack. It seems more intuative to me to have a button than some automated process in the looper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft to get the payjoin psbt tab to display a broadcast fallback tx button as a warning ux feature.
@arminsabouri I think I may be confused about how payjoin status works, as pressing this button still seems to send a payjoin through the regular flow. As a result I have not changed all of the subsequent notification UI elements as I am not sure if we need to create a new button in addition as a
Send PayjoinANDBroadcast Fallback TX