Skip to content

Use broadcast fallback button#10

Draft
benalleng wants to merge 1 commit intopayjoin:payjoin-v4from
benalleng:broadcast-fallback
Draft

Use broadcast fallback button#10
benalleng wants to merge 1 commit intopayjoin:payjoin-v4from
benalleng:broadcast-fallback

Conversation

@benalleng
Copy link

This is a draft to get the payjoin psbt tab to display a broadcast fallback tx button as a warning ux feature.

@arminsabouri I think I may be confused about how payjoin status works, as pressing this button still seems to send a payjoin through the regular flow. As a result I have not changed all of the subsequent notification UI elements as I am not sure if we need to create a new button in addition as a Send Payjoin AND Broadcast Fallback TX

@arminsabouri
Copy link
Collaborator

As a result I have not changed all of the subsequent notification UI elements as I am not sure if we need to create a new button in addition as a Send Payjoin AND Broadcast Fallback TX

Depends on the payjoin status I suppose. If as the sender, we just singed the psbt we should have an option to send as a normal or pj. Any other status should have an option to send as a fallback tx.

@benalleng
Copy link
Author

Should we take away the logic that sends the payjoin on the looper? With that logic still there a button to do it seems redundant

@arminsabouri
Copy link
Collaborator

Should we take away the logic that sends the payjoin on the looper? With that logic still there a button to do it seems redundant

Ack. It seems more intuative to me to have a button than some automated process in the looper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants