Not --all-features test suite

[benalleng]

Got everything compiling, however based on the current cfg flag layout in the integration tests, all the tests are run when v1 is enabled and none of the tests run when v2 is enabled

Closes #1019

Pull Request Checklist

Please confirm the following before requesting review:

• I have disclosed my use of
  AI
  in the body of this PR.

  I had chatgpt help me clean up some clones in the SenderBuilder while i was transitioning over to the NoopSessionPersister

• I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

[coveralls]

Pull Request Test Coverage Report for Build 21686578712

Details

• 113 of 117 (96.58%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 83.206%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
payjoin/src/core/uri/v1.rs	104	108	96.3%

Totals
Change from base Build 21675282596:	0.003%
Covered Lines:	10142
Relevant Lines:	12189

---

💛 - Coveralls

[benalleng]

based on the current cfg logic in the integration tests no tests run when v2 is the only thing enabled, perhaps someone could point me in the right direction on better splitting up the tests based on features

[DanGould]

My guess is that the v2 tests are relying on the URI builder from v1. We may need another builder that's v2-specific OR to expose this utility without feature gating it. The former seems more appropriate.

let mut pj_uri =
                build_v1_pj_uri(&pj_receiver_address, EXAMPLE_URL, OutputSubstitution::Enabled)?;

[benalleng]

My guess is that the v2 tests are relying on the URI builder from v1. We may need another builder that's v2-specific OR to expose this utility without feature gating it. The former seems more appropriate.

let mut pj_uri =
                build_v1_pj_uri(&pj_receiver_address, EXAMPLE_URL, OutputSubstitution::Enabled)?;

Its only the v2_to_v1 test that requires this setup whereas all the others rely on the usual session to create a pj_uri. I guess we could create a pj_uri with a session like that but then it really wouldn't be a v1 receiver

[DanGould]

Ah, and in that case it makes sense to test only with v1 compiled. Needs further investigation I suppose.

[DanGould]

@benalleng I may have unrequested reviewership by mistake. Is this ready for review?

[benalleng]

It is though with our source code now organized correctly #1019 (comment) we no longer fail on cargo test -p payjoin so before any actual code review I guess we need to ask ourselves if the addition of non --all-features tests still bring joy

This is incorrect we still fail on cargo test -p payjoin on master

[benalleng]

At the moment the line
https://github.com/benalleng/rust-payjoin/blob/d3bb1ab5e74f32b74dd2fb50000b920e514a03c9/payjoin/contrib/test.sh#L11
does not test anything with the v2 feature as all the v2 tests require enabling v1 with the way that the integration tests are organized at the moment.