WIP - Include outcome in close#1181
Closed
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
Closed
Conversation
Collaborator
Author
Closing |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For @zealsham, related to #1164 . When we we're talking about include the session outcome in
close()this is kinda what I had in mind. The idea being that applications can scrutinize the outcome in close and make a decision to fallback or not. Alternatively you could create seperate types for "session closing events" and "protocol events" -- which is nice for type safety -- but seems to complicate to code.However, this approach is a bit awkward for the application. It implies that they have a rpc client where ever they are doing db things or they will save the action to fallback and do it else where. Realistically I see applications replaying a session, seeing the status (
rust-payjoin/payjoin/src/core/send/v2/session.rs
Line 81 in 2009ac0
Note: this pr is just informational and meant to be closed.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.