Skip to content

WIP - Include outcome in close#1181

Closed
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
arminsabouri:close-with-outcome
Closed

WIP - Include outcome in close#1181
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
arminsabouri:close-with-outcome

Conversation

@arminsabouri
Copy link
Collaborator

For @zealsham, related to #1164 . When we we're talking about include the session outcome in close() this is kinda what I had in mind. The idea being that applications can scrutinize the outcome in close and make a decision to fallback or not. Alternatively you could create seperate types for "session closing events" and "protocol events" -- which is nice for type safety -- but seems to complicate to code.

However, this approach is a bit awkward for the application. It implies that they have a rpc client where ever they are doing db things or they will save the action to fallback and do it else where. Realistically I see applications replaying a session, seeing the status (

pub fn status(&self) -> SessionStatus {
) is fatally closed due to an error, and then fetching and broadcasting the fallback. Perhaps that is the simplest solution. cc @spacebear21

Note: this pr is just informational and meant to be closed.

Pull Request Checklist

Please confirm the following before requesting review:

@arminsabouri
Copy link
Collaborator Author

Note: this pr is just informational and meant to be closed.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant