Merged
Conversation
Include C# bindings, add links to published packages, and clean up some stale writing.
Collaborator
Pull Request Test Coverage Report for Build 22244027455Details
💛 - Coveralls |
spacebear21
force-pushed
the
ffi-readme-updates
branch
from
7da0010 to
dcfeb96
Compare
arminsabouri
approved these changes
Feb 21, 2026
| This repository creates Payjoin libraries for various programming languages, all using the Rust-based [Payjoin Dev Kit](https://github.com/payjoin/rust-payjoin) as the core implementation of BIP-77. | ||
|
|
||
| Our mission is to provide developers with cross-language libraries that seamlessly integrate with different platform languages. By offering support for multiple languages, we aim to enhance the accessibility and usability of Payjoin, empowering developers to incorporate this privacy-enhancing feature into their applications, no matter their preferred programming language. | ||
| Our mission is to provide developers with cross-language libraries that seamlessly integrate with different platform languages. By offering support for multiple languages, we aim to enhance the accessibility and usability of Payjoin, empowering developers to incorporate it into their applications, no matter their preferred programming language. |
Collaborator
There was a problem hiding this comment.
Does this read better?
Suggested change
| Our mission is to provide developers with cross-language libraries that seamlessly integrate with different platform languages. By offering support for multiple languages, we aim to enhance the accessibility and usability of Payjoin, empowering developers to incorporate it into their applications, no matter their preferred programming language. | |
| Our mission is to provide developers with cross-language libraries that seamlessly integrate with different platform languages. By offering support for multiple languages, we aim to enhance the accessibility and usability of Payjoin, empowering developers to incorporate Payjoin into their applications, no matter their preferred programming language. |
Collaborator
Author
There was a problem hiding this comment.
"...usability of Payjoin, empowering developers to incorporate Payjoin" I used "it" to avoid back to back repetition but it works either way imo
| | Python | linux, macOS | [payjoin-ffi/python](python) | [pypi](https://pypi.org/project/payjoin) | | ||
| | Dart | linux, macOS | [payjoin-ffi/dart](dart) | [pub.dev](https://pub.dev/packages/payjoin) | | ||
| | JavaScript | linux, macOS | [payjoin-ffi/javascript](javascript) | [npm](https://www.npmjs.com/package/payjoin) | | ||
| | C# | linux, macOS, windows | [payjoin-ffi/csharp](csharp) | [nuget](https://www.nuget.org/packages/Payjoin) | |
Collaborator
There was a problem hiding this comment.
OCD nit. Match with the other urls
Suggested change
| | C# | linux, macOS, windows | [payjoin-ffi/csharp](csharp) | [nuget](https://www.nuget.org/packages/Payjoin) | | |
| | C# | linux, macOS, windows | [payjoin-ffi/csharp](csharp) | [nuget](https://www.nuget.org/packages/payjoin) | |
Collaborator
There was a problem hiding this comment.
That is how it is listed.. blame Dan for publishing it with a capital P lol
Collaborator
Author
There was a problem hiding this comment.
Blame C# for being weird, all their packages are capitalized https://www.nuget.org/packages
Collaborator
|
The JS job is failing and it seems unrelated to this PR Is this a known issue? |
Collaborator
That's what #1349 addresses. We need to lock wasm-bindgen |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include C# bindings, add links to published packages, and clean up some stale writing.