Skip to content

Update uniffi-dart with named params#1364

Merged
benalleng merged 2 commits intopayjoin:masterfrom
spacebear21:dart-named-params
Feb 26, 2026
Merged

Update uniffi-dart with named params#1364
benalleng merged 2 commits intopayjoin:masterfrom
spacebear21:dart-named-params

Conversation

@spacebear21
Copy link
Collaborator

@spacebear21 spacebear21 commented Feb 26, 2026

Uniffi-Dart/uniffi-dart#112 introduces named parameters in generated APIs. Update the uniffi-dart version and all dart tests accordingly. Leave in Draft until upstream PR gets merged and the ref is updated in Cargo.toml

Co-authored by Claude Opus 4.6

Pull Request Checklist

Please confirm the following before requesting review:

Uniffi-Dart/uniffi-dart#112 introduces named
parameters in generated APIs. Update the uniffi-dart version and all
dart tests accordingly.
@spacebear21
Copy link
Collaborator Author

I'm not sure why the C# build is failing, seems unrelated to the changes in the PR

@spacebear21
Copy link
Collaborator Author

cc @ValeraFinebits curious if have any insights on the C# error. Robot says to add this to payjoin-ffi/csharp/Payjoin.Tests.csproj:

<PropertyGroup>
  <GenerateAppHost>false</GenerateAppHost>
</PropertyGroup>

but I don't know what that means or why it just started failing now.

@benalleng
Copy link
Collaborator

Robot says to add this to payjoin-ffi/csharp/Payjoin.Tests.csproj:

It's my understanding that this addition just skips the apphost binary generation that NET8 is creating. I also see that there is mention of a differing dotnet version in the log /dotnet/sdk/10.0.102 I wonder if this is causing problems as we are explicitly installing 8.0.x

@chavic
Copy link
Collaborator

chavic commented Feb 26, 2026

@spacebear21 @benalleng
I dug into the C# CI failure, and it looks environment-related, not from your Dart/C# changes. On February 26, 2026 (ubuntu24/20260224.36), dotnet test is running under /usr/share/dotnet/sdk/10.0.102 and fails with MSB3030 because obj/Debug/net8.0/apphost is missing; a prior green run on February 25, 2026 (ubuntu24/20260201.15) used SDK 8.0.418 and passed.

Something else can do, in .github/workflows/csharp.yml, force an isolated .NET 8 toolchain (install to a custom path), set DOTNET_ROOT and prepend it to PATH, set DOTNET_MULTILEVEL_LOOKUP=0, and add a dotnet --version check before tests to ensure the job is actually running on 8.x.

Recent ubuntu-latest image updates changed toolchain selection in
the C# workflow. Even with setup-dotnet requesting 8.0.x, dotnet
test can run under SDK 10 and fail with MSB3030 when apphost is
missing.

Add a csharp/global.json to pin SDK resolution to .NET 8 and keep
test build behavior stable across runner image changes. Also print
dotnet version and installed SDKs in CI logs so future drift is
immediately visible.
@spacebear21 spacebear21 marked this pull request as ready for review February 26, 2026 20:52
@spacebear21 spacebear21 mentioned this pull request Feb 26, 2026
2 tasks
Copy link
Collaborator

@chavic chavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d06394e

This was the notable comment that the second commit solves (Its just csharp semantic versioning)

Add global.json with rollForward: latestFeature so the CLI uses any 8.0.xxx but never rolls forward to 9.0+.

@benalleng benalleng merged commit 88909e9 into payjoin:master Feb 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants