Update uniffi-dart with named params#1364
Conversation
Uniffi-Dart/uniffi-dart#112 introduces named parameters in generated APIs. Update the uniffi-dart version and all dart tests accordingly.
2075a74 to
9f22faf
Compare
|
I'm not sure why the C# build is failing, seems unrelated to the changes in the PR |
|
cc @ValeraFinebits curious if have any insights on the C# error. Robot says to add this to <PropertyGroup>
<GenerateAppHost>false</GenerateAppHost>
</PropertyGroup>but I don't know what that means or why it just started failing now. |
It's my understanding that this addition just skips the apphost binary generation that NET8 is creating. I also see that there is mention of a differing dotnet version in the log |
|
@spacebear21 @benalleng Something else can do, in |
Recent ubuntu-latest image updates changed toolchain selection in the C# workflow. Even with setup-dotnet requesting 8.0.x, dotnet test can run under SDK 10 and fail with MSB3030 when apphost is missing. Add a csharp/global.json to pin SDK resolution to .NET 8 and keep test build behavior stable across runner image changes. Also print dotnet version and installed SDKs in CI logs so future drift is immediately visible.
3155692 to
d06394e
Compare
Uniffi-Dart/uniffi-dart#112 introduces named parameters in generated APIs. Update the uniffi-dart version and all dart tests accordingly. Leave in Draft until upstream PR gets merged and the ref is updated in Cargo.toml
Co-authored by Claude Opus 4.6
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.