Use internal Url struct in favor of url::Url to minimize the url dep in payjoin#1377
Draft
benalleng wants to merge 8 commits intopayjoin:masterfrom
Draft
Use internal Url struct in favor of url::Url to minimize the url dep in payjoin#1377benalleng wants to merge 8 commits intopayjoin:masterfrom
benalleng wants to merge 8 commits intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22596246534Details
💛 - Coveralls |
Collaborator
Author
|
Drafting for mutants |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1124
This adds the internal Url Struct to no longer depend on the url crate directly for it.
in addition I also transitioned to the http crate instead of the bhttp/http dep as that also depends on url internally.
However we still have reqwest inside payjoin url from payjoin-directory and test-utils which pull in the url dep.
I have also added a fuzz target, which already helped me better shape the parse function better.
I have only ran the fuzzer for a limited amount of time however and some more cpu hours might be helpful
Claude really helped me get through the brunt of this.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.