Skip to content

Fix standup syntax#1388

Closed
DanGould wants to merge 19 commits intopayjoin:masterfrom
DanGould:fix-standup-syntax
Closed

Fix standup syntax#1388
DanGould wants to merge 19 commits intopayjoin:masterfrom
DanGould:fix-standup-syntax

Conversation

@DanGould
Copy link
Contributor

@DanGould DanGould commented Mar 6, 2026

Pull Request Checklist

Please confirm the following before requesting review:

agentbox and others added 19 commits March 2, 2026 18:37
Enable advisory (non-blocking) AI review on PRs touching
Rust source in payjoin/ and payjoin-cli/. Uses the "chill"
profile with noisy features disabled. Path instructions
focus on C-CALLER-CONTROL violations (pub fn taking &T but
internally cloning) and broader Rust API guidelines from
the checklist at rust-lang.github.io/api-guidelines.

Closes payjoin#1374
Enable auto_review.drafts so CodeRabbit reviews draft PRs
instead of skipping them. Disable review_status since
CodeRabbit already reports via commit status checks
(pending/success), making the walkthrough status messages
redundant.
Enable CodeRabbit reviews on draft PRs
Disable all CodeRabbit noise, keep only path reviews
Replace the two-step Issue→Discussion standup flow with a
single Discussion-based system that auto-gathers each
contributor's weekly activity (merged PRs, reviews, issues)
and creates pre-populated threaded replies.

Changes:
- Add create_standup_discussion.py with GitHub API activity
  gathering and GraphQL Discussion/comment creation
- Update standup-prompt.yml to call new script and pass
  DISCUSSION_CATEGORY_NODE_ID
- Remove compile_standup.py and standup-compile.yml since
  the Discussion IS the standup (no compile step needed)
- Remove create_standup_issue.py (superseded)
When DRY_RUN is set, gather activity and print what would be
posted without creating a Discussion or sending notifications.
Runs Tuesday 06:00 UTC before the standup
meeting. Edits the Discussion body to show which contributors
replied to their thread. Uses an HTML comment marker so
re-runs update in place rather than appending.
The bot token is an org member, so org:payjoin searches
return results from private repos. Those titles and URLs
would be published into the public Discussion, leaking
private work.

Replace the org: search qualifier with explicit repo:
qualifiers for each public repo to ensure only public
activity is surfaced.
Search explicit public repos instead of org
The bot token is an org member, so org:payjoin searches
return results from private repos. Those titles and URLs
would be published into the public Discussion, leaking
private work.

Replace the org: search qualifier with explicit repo:
qualifiers for each public repo to ensure only public
activity is surfaced.
Search explicit public repos instead of org
@DanGould DanGould closed this Mar 6, 2026
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22753769717

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.497%

Totals Coverage Status
Change from base Build 22741440695: 0.0%
Covered Lines: 10638
Relevant Lines: 12895

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants