Ensure random relay selection with fixed ohttp-keys config#1390
Open
benalleng wants to merge 1 commit intopayjoin:masterfrom
Open
Ensure random relay selection with fixed ohttp-keys config#1390benalleng wants to merge 1 commit intopayjoin:masterfrom
benalleng wants to merge 1 commit intopayjoin:masterfrom
Conversation
This fixes a bug whereby the relay selection was skipped if the config set a fixed value for the ohttp-keys.
Collaborator
Pull Request Test Coverage Report for Build 22781790124Details
💛 - Coveralls |
Contributor
|
tested ACK 6097008 all tests passing locally the fix is minimal and reuses |
spacebear21
approved these changes
Mar 6, 2026
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
utACK 6097008, though this makes me wonder if there is any benefit at all of having ohttp_keys in the cli config? We could just return the ValidatedOhttpKeys from fetch_ohttp_keys for the same effect, making the if/else block irrelevant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1384
This fixes a bug whereby the relay selection was skipped if the config set a fixed value for the ohttp-keys.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.