Open
Conversation
Contributor
Author
|
@benalleng would Appreciate a review |
Collaborator
Pull Request Test Coverage Report for Build 22877321807Details
💛 - Coveralls |
benalleng
reviewed
Mar 9, 2026
flake.nix
Outdated
| builtins.removeAttrs pythonWorkspace.deps.all [ "payjoin" ] | ||
| )).overrideAttrs | ||
| { | ||
| # Remove reflexive symlink to prevent fixupPhase failure (noBrokenSymlinks). |
Collaborator
There was a problem hiding this comment.
I would add an additional comment that we believe this is an error upstream to remind us to check the pyproject-nix repo to see if they got a change merged for us to be able to remove this hack
benalleng
reviewed
Mar 9, 2026
Collaborator
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
Looking good, go ahead and make an issue upstream and link it in the comment about the preFixup phase hack to
Adds `nix develop .#python` for payjoin-ffi/python work. Provides uv, Python, and Rust MSRV in one shell. Co-Authored-By: Brandon Lucas <thebrandonlucas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nix develop .#pythonfor payjoin-ffi/python work. Provides uv, Python, and Rust MSRV in one shell.superseeds #864
went through comments and followed the nix2python approach as suggested by Yuval in PR
Address #457 (comment)
Note to reviewers:
should we make the script in contrib/test.sh also what runs in CI python.yaml to keep changes consistent or keep current worklow
co authored using claude sonnet 4.6
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.