Update mailroom README description#1402
Open
spacebear21 wants to merge 1 commit intopayjoin:masterfrom
Open
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22873367759Details
💛 - Coveralls |
benalleng
requested changes
Mar 9, 2026
Collaborator
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
Small nit but I think I'd like it to specifically mention Oblivious Http
payjoin-mailroom/README.md
Outdated
| payjoin-mailroom is a single, lightweight binary that bundles the two server-side roles required by BIP 77 Async Payjoin: | ||
|
|
||
| - **Payjoin Directory**: a store-and-forward mailbox that holds small, ephemeral, end-to-end encrypted payloads so a sender and receiver can complete a payjoin asynchronously (they don't need to be online at the same time). | ||
| - **OHTTP Relay**: a simple HTTP proxy that separates client IP addresses from the directory, preventing the directory from correlating users with their network identity. |
Collaborator
There was a problem hiding this comment.
I think its important to specify that this is using oblivious http
Suggested change
| - **OHTTP Relay**: a simple HTTP proxy that separates client IP addresses from the directory, preventing the directory from correlating users with their network identity. | |
| - **OHTTP Relay**: a forwarding proxy utilizing Oblivious HTTP that separates client IP addresses from the directory, preventing the directory from correlating users with their network identity. |
Collaborator
Author
There was a problem hiding this comment.
Updated with a link to the OHTTP wiki page. I also updated the #1401 with similar wording.
Use the landing page copy to better describe the two server-side roles bundled by payjoin-mailroom, and drop the now-broken links to payjoin-directory and ohttp-relay.
spacebear21
force-pushed
the
fix-directory-link
branch
from
db25d9a to
44b2bff
Compare
Contributor
|
LGTM, ACK |
benalleng
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use the landing page copy from #1401 to better describe the two server-side roles bundled by payjoin-mailroom, and drop the now-broken links to payjoin-directory and ohttp-relay.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.