De-duplicate non-witness data weight const#875
Closed
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
Closed
De-duplicate non-witness data weight const#875arminsabouri wants to merge 1 commit intopayjoin:masterfrom
arminsabouri wants to merge 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 16269868202Details
💛 - Coveralls |
benalleng
reviewed
Jul 14, 2025
Collaborator
There was a problem hiding this comment.
If you plan on moving this up would you consider adding back an assert that caught a mutant removed in #847 that I missed in review.
https://github.com/payjoin/rust-payjoin/pull/847/files#r2205267477
Collaborator
|
This is obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hoping to also get rid of the length numbers and replace them with rust bitcoin consts (e.g
bitcoin::Outpoint::SIZE) but alas those values are private.