feat(ui): batch relationship value fetches to reduce N*M API requests#15758
Open
jhb-dev wants to merge 5 commits intopayloadcms:mainfrom
Open
feat(ui): batch relationship value fetches to reduce N*M API requests#15758jhb-dev wants to merge 5 commits intopayloadcms:mainfrom
jhb-dev wants to merge 5 commits intopayloadcms:mainfrom
Conversation
Contributor
Author
|
The failing CI check ("E2E - versions 1/3") is a pre-existing flaky test on I'd appreciate a review from the team to get your thoughts on this approach before moving forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Introduces a
RelationshipValueCacheProviderthat batches document title fetches across allRelationshipInputfield instances. Instead of each relationship field making its own REST request on mount, all fields that mount in the same render tick have their ID lookups collected and fired as a single request per collection.Why?
When relationship fields are placed inside arrays (or blocks), each row's relationship field independently fetches its referenced document title via REST. With N array rows and M relationship fields per row, this produces N*M parallel requests. This causes:
How?
RelationshipValueCacheProvider(packages/ui/src/providers/RelationshipValueCache/index.tsx) usesqueueMicrotaskto collect allgetDoc()calls within a single tick, then fires one batched request per collection usingwhere: { id: { in: [...allIds] } }collection:locale:idkey so subsequent renders don't refetchPromise.allRelationshipInputchecks the shared cache before requesting, and delegates uncached IDs to the batching providerDocumentEventsProviderFixes #13329