fix(ui): update status to published after locale-specific publish#15765
Open
maximseshuk wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): update status to published after locale-specific publish#15765maximseshuk wants to merge 1 commit intopayloadcms:mainfrom
maximseshuk wants to merge 1 commit intopayloadcms:mainfrom
Conversation
publishSpecificLocale callback was not resetting unpublishedVersionCount and mostRecentVersionIsAutosaved, causing the Status component to show "Changed" instead of "Published" after a locale-specific publish.
maximseshuk
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When
localizeStatusis enabled anddefaultLocalePublishOptionis set toactive, publishing a specific locale leaves the document status showing "Changed" instead of "Published" until the page is refreshed.Why?
The
publishSpecificLocalecallback inPublishButtononly calledsetHasPublishedDoc(true)on success, but did not resetunpublishedVersionCountormostRecentVersionIsAutosaved. TheStatuscomponent usesunpublishedVersionCount > 0 && hasPublishedDocto render "Changed", so the stale count kept the status incorrect.The
publish(all locales) callback already handled this correctly,publishSpecificLocalewas just missing the same state resets.How?
Added
setUnpublishedVersionCount(0)andsetMostRecentVersionIsAutosaved(false)to thepublishSpecificLocalesuccess handler, matching whatpublishalready does. Added an e2e test that reproduces the issue.