fix(drizzle): convert equals/not_equals to in/not_in for hasMany relationship array values#15766
Open
maximseshuk wants to merge 2 commits intopayloadcms:mainfrom
Open
fix(drizzle): convert equals/not_equals to in/not_in for hasMany relationship array values#15766maximseshuk wants to merge 2 commits intopayloadcms:mainfrom
maximseshuk wants to merge 2 commits intopayloadcms:mainfrom
Conversation
… on relationship and upload fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When the value is an array, converts
equals→inandnot_equals→not_infor relationship/upload fields insanitizeQueryValue.Why?
When filtering relationship fields with
equalsornot_equalsusing array values (e.g.,{ relatedPost: { equals: [1] } }), SQL adapters (Postgres, SQLite) throw because the=operator doesn't accept arrays.How?
Added an
Array.isArray(formattedValue)guard at the end ofsanitizeQueryValuethat swaps the operator when the value is an array. It runs after all type conversions (UUID validation, date formatting, ID casting) so it works with already-sanitized values. Same pattern as the existingcontains→equalsswap for hasMany relationships on line 248.Also added integration tests covering
equalsandnot_equalswith array values for both hasMany and non-hasMany relationship fields.