Check type of tag before preventing default - #1
Open
elHornair wants to merge 3 commits into
Open
Conversation
Author
|
Update: Changed PR so the default behaviour is never prevented at all. I think the event handlers themselves should take care of preventing the default behaviour if needed, because sometimes you want to do something custom but still let the browser take care of the click. Or you want the event to continue bubbling. |
Author
|
@pazguille Just saw that the build is failing. I can try to fix it, but maybe you could first comment on the PR? Because there is no need for me to fix the tests if you don't agree with the PR and it won't be merged anyway ;) |
Owner
|
Sorry for the delay :( Yes, you can fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the default behaviour of the browser should only be prevented if the clicked element is an anchor. In my case, I was having trouble with Checkboxes that wouldn't get checked anymore because I was using Clicktap on them to trigger some additional JS.