Validate circular and multi-file schema references instead of failing#290
Merged
Conversation
Previously, schemas containing circular or external/multi-file $refs were fully inlined before compilation, which failed to render and surfaced a "failed schema rendering" error rather than validating the payload. These schemas are now compiled from named JSON Schema resources that preserve the $ref structure across documents, so circular and multi-file references validate correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 97.65% 97.97% +0.31%
==========================================
Files 65 67 +2
Lines 7133 7445 +312
==========================================
+ Hits 6966 7294 +328
+ Misses 134 125 -9
+ Partials 33 26 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, schemas containing circular or external/multi-file $refs were fully inlined before compilation, which failed to render and surfaced a "failed schema rendering" error rather than validating the payload. These schemas are now compiled from named JSON Schema resources that preserve the $ref structure across documents, so circular and multi-file references validate correctly.
#287 #288