Skip to content

Use lldb shell script when running on MacOSX #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzxuanyuan wants to merge 6 commits into
base: zzxuanyuan-sigtest-sept
Choose a base branch
from
Open

Use lldb shell script when running on MacOSX #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cf76c1
macosx does not recognize pipe-related values if they were initialize…
zzxuanyuan Feb 26, 2018
ac9e6cc
Keep macosx call StackTrace function.
zzxuanyuan Feb 26, 2018
d8fce1e
Reverted MacOSX stacktrace to Linux implementation.
zzxuanyuan Apr 5, 2018
ec8e186
Add lldb-backtrace script for MacOSX.
zzxuanyuan Apr 5, 2018
8c1bb9a
MacOSX has to explicitly initialize static struct, otherwise the pipe…
zzxuanyuan Apr 6, 2018
433a27c
Use lldb thread command
zzxuanyuan Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 27 additions & 22 deletions core/unix/src/TUnixSignalManager.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,17 @@

class TFdSet;

static const int kStringLength = 255;

struct StackTraceHelper_t {
char fShellExec[kStringLength];
char fPidString[kStringLength];
char fPidNum[kStringLength];
int fParentToChild[2];
int fChildToParent[2];
std::unique_ptr<std::thread> fHelperThread;
};

#if defined(HAVE_DLADDR) && !defined(R__MACOSX)
////////////////////////////////////////////////////////////////////////////////

Expand Down Expand Up @@ -222,23 +233,7 @@ static int SignalSafeErrWrite(const char *text) {

//---- helper -----------------------------------------------------------------

static const int kStringLength = 255;

static struct StackTraceHelper_t {
char fShellExec[kStringLength];
char fPidString[kStringLength];
char fPidNum[kStringLength];
int fParentToChild[2];
int fChildToParent[2];
std::unique_ptr<std::thread> fHelperThread;
} gStackTraceHelper = { // the order of the signals should be identical
{ },
{ },
{ },
{-1,-1},
{-1,-1},
nullptr
};
static StackTraceHelper_t gStackTraceHelper;

static char * const kStackArgv[] = {gStackTraceHelper.fShellExec, gStackTraceHelper.fPidString, gStackTraceHelper.fPidNum, nullptr};

Expand Down Expand Up @@ -272,6 +267,13 @@ void TUnixSignalManager::Init()

fSignals = new TFdSet;

//--- initialize pipe-related data structer here, macosx does not recognize their values if they were inialized after UnixSignal functions
gStackTraceHelper.fParentToChild[0] = -1;
gStackTraceHelper.fParentToChild[1] = -1;
gStackTraceHelper.fChildToParent[0] = -1;
gStackTraceHelper.fChildToParent[1] = -1;
gStackTraceHelper.fHelperThread = nullptr;

//--- install default handlers
UnixSignal(kSigChild, SigHandler);
UnixSignal(kSigBus, SigHandler);
Expand All @@ -290,22 +292,25 @@ void TUnixSignalManager::Init()
}

#ifdef ROOTETCDIR
#if defined(R__MACOSX)
if(snprintf(gStackTraceHelper.fPidString, kStringLength-1, "%s/lldb-backtrace.sh", ROOTETCDIR) >= kStringLength) {
#else
if(snprintf(gStackTraceHelper.fPidString, kStringLength-1, "%s/gdb-backtrace.sh", ROOTETCDIR) >= kStringLength) {
#endif
SignalSafeErrWrite("Unable to pre-allocate executable information");
return;
}
#else
#if defined(R__MACOSX)
if(snprintf(gStackTraceHelper.fPidString, kStringLength-1, "%s/etc/lldb-backtrace.sh", gSystem->Getenv("ROOTSYS")) >= kStringLength) {
#else
if(snprintf(gStackTraceHelper.fPidString, kStringLength-1, "%s/etc/gdb-backtrace.sh", gSystem->Getenv("ROOTSYS")) >= kStringLength) {
#endif
SignalSafeErrWrite("Unable to pre-allocate executable information");
return;
}
#endif

gStackTraceHelper.fParentToChild[0] = -1;
gStackTraceHelper.fParentToChild[1] = -1;
gStackTraceHelper.fChildToParent[0] = -1;
gStackTraceHelper.fChildToParent[1] = -1;

StackTraceHelperInit();
}

Expand Down
41 changes: 41 additions & 0 deletions etc/lldb-backtrace.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#!/bin/sh

# This script is used by TUnixSystem::StackTrace() on MacOS X if lldb is supported.

tempname=`basename $0 .sh`

OUTFILE=/dev/stdout

if [ `uname -s` != "Darwin" ]; then

echo "lldb stacktrace is only supported on MacOSX."
exit 1

else

if test $# -lt 1; then
echo "Usage: ${tempname} <process-id>" 1>&2
exit 1
fi

TMPFILE=`mktemp -q /tmp/${tempname}.XXXXXX`
if test $? -ne 0; then
echo "${tempname}: can't create temp file, exiting..." 1>&2
exit 1
fi

backtrace="thread backtrace all"

echo $backtrace > $TMPFILE

LLDB=${LLDB:-lldb}

# Run LLDB, strip out unwanted noise.
$LLDB -b -x -s $TMPFILE -p $1 2>&1 < /dev/null |
sed -n \
-e '/[Tt]hread #[0-9]/p' \
-e '/[Ff]rame #[0-9]/p' > $OUTFILE

rm -f $TMPFILE

fi