Skip to content

Conversation

@meirm
Copy link

@meirm meirm commented Jun 16, 2015

  • Add option to use Timer1 or Timer3 library which allows you to use GRBL/UNO or RAMPS/MEGA HW.
  • Add optional Z axis.
  • Use fastio to speed up the code.
  • Add more Gcode commands.
  • Make all axis 32bit to allow work on big machines.

* Add option to use Timer1 or Timer3 library which allows you to use GRBL/UNO or RAMPS/MEGA HW.
* Add optional Z axis.
* Use fastio to speed up the code.
* Add more Gcode commands.
* Make all axis 32bit to allow work on big machines.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positions should be modal; that is, if I don't specify an X coordinate in a command, the default should be the current/previous X coordinate, rather than 0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is modal, it you look at the execution of the task it is treated to support relative/absolute positions.
Setting the values at the first parsing of the buffer leads to multiple conflicts. It was hard to troubleshoot , cause when you send the commands one by one there is no effect. When running a gcode file is that the conflicts get afloat.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this works for relative, but there perhaps should be a conditional here. The new code treats "G1 X555" as "G1 X555 Y0 Z0," which is correct for relative positioning but is not correct for absolute positioning.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOMEDELAY/10, as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants