refactor: switch to serde_core and remove Cargo.lock#22
Open
giuseppe998e wants to merge 3 commits into
Open
Conversation
Libraries should not include a “Cargo.lock” file
Using 'serde_core' improves compilation times by allowing the crate to be compiled in parallel with the heavier 'serde_derive' macro, bypassing a major bottleneck if derive is used elsewhere in the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Here is a small PR focused mainly on optimizing compilation times.
What’s included:
serdedependency withserde_core.This helps speed up compilation times by allowing the crate to build in parallel with the heavier
serde_derivemacro, bypassing a major bottleneck if derive is used elsewhere in the project.Cargo.lockfile to follow the Rust convention that libraries should not include lockfiles.clippywarning on a test assert.Hope this helps the project! Let me know if you’d like me to tweak anything or split the commits differently.
Thanks for your time!