Open
Conversation
Author
|
Eventually, we probably want to merge with a newer version of upstream qemu (https://gitlab.com/qemu-project/qemu) but that may be a large undertaking and this will improve the development workflow in the short/medium term. |
SteveUcho
pushed a commit
to SteveUcho/pebble-qemu
that referenced
this pull request
May 7, 2025
Address a memory leak bug in the usages of timer_del().
The issue arises from the incorrect use of the ambiguous timer API
timer_del(), which does not free the timer object. The LeakSanitizer
report this issue during fuzzing. The correct API timer_free() freed
the timer object instead.
=================================================================
==2586273==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x55f2afd89879 in calloc /llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:75:3
pebble-dev#1 0x7f443b93ac50 in g_malloc0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5ec50)
pebble-dev#2 0x55f2b053962e in timer_new include/qemu/timer.h:542:12
pebble-dev#3 0x55f2b0514771 in timer_new_us include/qemu/timer.h:582:12
pebble-dev#4 0x55f2b0514288 in lsi_scsi_realize hw/scsi/lsi53c895a.c:2350:24
pebble-dev#5 0x55f2b0452d26 in pci_qdev_realize hw/pci/pci.c:2174:9
Signed-off-by: Zheng Huang <hz1624917200@outlook.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <73cd69f9-ff9b-4cd4-b8aa-265f9d6067b9@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Hexxeh
approved these changes
Aug 27, 2025
|
Oh, one thing I missed, the commit messages should probably use the conventional commits style like the previous PRs and firmware repo: https://www.conventionalcommits.org/en/v1.0.0/ |
BREAKING CHANGE: drop support for Python 2 Signed-off-by: Justin Hendrick <justinjhendrick@gmail.com>
justinjhendrick
force-pushed
the
support_py3_for_build
branch
from
4382bbc to
f10994a
Compare
Author
|
@Hexxeh, I've rewritten the commit message |
Hexxeh
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Make it easier to build this project from source
What I changed:
strvsbytesdifferencesordereddict.pywithcollections.OrderedDictsocket.error.argsto check forEAGAINstring.maketranswithstr.maketransinspect.getargspecwithinspect.getfullargspecOSError. Just callstron itconfigureto accept python3.8 and newerWarnings with this change:
How I tested this:
./configure --disable-werror --enable-debug --target-list="arm-softmmu" --extra-cflags=-DSTM32_UART_NO_BAUD_DELAYmakepython -m mypy --check-untyped-defs --exclude scripts/analyze-migration.py --exclude tests/image-fuzzer/qcow2/ . --disable-error-code='import-untyped' --disable-error-code='var-annotated'