Address review feedback for no-permit EVM offramp fallback

apps/api/src/api/services/phases/handlers/squidrouter-permit-execution-handler.ts

@@ -128,6 +128,15 @@ export class SquidrouterPermitExecuteHandler extends BasePhaseHandler {
     if (!receipt || receipt.status !== "success") {
       throw this.createRecoverableError(`${label} tx failed: ${hash}`);
     }
+
+    // Verify the transaction was sent by the expected wallet
+    const expectedFrom = (state.state.walletAddress as string)?.toLowerCase();
+    if (expectedFrom && receipt.from.toLowerCase() !== expectedFrom) {
+      throw this.createUnrecoverableError(
+        `${label} tx from address mismatch: expected ${expectedFrom}, got ${receipt.from.toLowerCase()}`
+      );
+    }
+
     logger.info(`${label} tx confirmed: ${hash}`);
   }
 

apps/api/src/api/services/transactions/offramp/routes/evm-to-alfredpay.ts

@@ -22,7 +22,16 @@ import {
   UnsignedTx
 } from "@vortexfi/shared";
 import Big from "big.js";
-import { encodeAbiParameters, encodeFunctionData, keccak256, PublicClient, pad, parseAbiParameters, toHex } from "viem";
+import {
+  ContractFunctionExecutionError,
+  encodeAbiParameters,
+  encodeFunctionData,
+  keccak256,
+  pad,
+  parseAbiParameters,
+  PublicClient,
+  toHex
+} from "viem";
 import { privateKeyToAccount } from "viem/accounts";
 import { MOONBEAM_EXECUTOR_PRIVATE_KEY } from "../../../../../constants/constants";
 import AlfredPayCustomer from "../../../../../models/alfredPayCustomer.model";
@@ -240,8 +249,14 @@ export async function prepareEvmToAlfredpayOfframpTransactions({
       args: [userAddress],
       functionName: "nonces"
     })) as bigint;
-  } catch {
-    userNonce = null;
+  } catch (error) {
+    // Only treat contract-level failures (function not found / execution reverted) as "no permit".
+    // Re-throw network/transport errors so the request can be retried.
+    if (error instanceof ContractFunctionExecutionError) {
+      userNonce = null;
+    } else {
+      throw error;
+    }
   }
   const supportsPermit = userNonce !== null;
 

apps/frontend/src/pages/progress/phaseMessages.ts

@@ -100,9 +100,17 @@ export function getMessageForPhase(ramp: RampState | undefined, t: TFunction<"tr
       assetSymbol: outputAssetSymbol
     }),
     squidRouterApprove: getSquidRouterSwapMessage(),
-    squidRouterNoPermitApprove: getSquidRouterPermitMessage(),
-    squidRouterNoPermitSwap: getSquidRouterPermitMessage(),
-    squidRouterNoPermitTransfer: getSquidRouterPermitMessage(),
+    squidRouterNoPermitApprove: t("pages.progress.squidRouterNoPermitApprove", {
+      assetSymbol: inputAssetSymbol,
+      fromNetwork: quote.from
+    }),
+    squidRouterNoPermitSwap: t("pages.progress.squidRouterNoPermitSwap", {
+      assetSymbol: inputAssetSymbol,
+      fromNetwork: quote.from
+    }),
+    squidRouterNoPermitTransfer: t("pages.progress.squidRouterNoPermitTransfer", {
+      assetSymbol: inputAssetSymbol
+    }),
     squidRouterPay: getSquidRouterSwapMessage(),
     squidRouterPermitExecute: getSquidRouterPermitMessage(),
     squidRouterSwap: getSquidRouterSwapMessage(),

apps/frontend/src/translations/en.json

@@ -1185,6 +1185,9 @@
       "pendulumToAssethubXcm": "Transferring {{assetSymbol}} from Pendulum --> AssetHub",
       "pendulumToHydrationXcm": "Transferring {{assetSymbol}} from Pendulum --> Hydration",
       "pendulumToMoonbeamXcm": "Transferring {{assetSymbol}} from Pendulum --> Moonbeam",
+      "squidRouterNoPermitApprove": "Approving {{assetSymbol}} for transfer from {{fromNetwork}}",
+      "squidRouterNoPermitSwap": "Transferring {{assetSymbol}} from {{fromNetwork}} via bridge",
+      "squidRouterNoPermitTransfer": "Transferring {{assetSymbol}} to processing account",
       "squidRouterPermitExecute": "Initializing the transfer of {{assetSymbol}} from {{fromNetwork}}",
       "squidRouterSwap": "Transferring {{assetSymbol}} from {{fromNetwork}} to {{toNetwork}}",
       "stellarPayment": "Transferring {{assetSymbol}} from Stellar --> local partner",

apps/frontend/src/translations/pt.json

@@ -1189,6 +1189,9 @@
       "pendulumToAssethubXcm": "Transferindo {{assetSymbol}} de Pendulum --> AssetHub",
       "pendulumToHydrationXcm": "Transferindo {{assetSymbol}} de Pendulum --> Hydration",
       "pendulumToMoonbeamXcm": "Transferindo {{assetSymbol}} de Pendulum --> Moonbeam",
+      "squidRouterNoPermitApprove": "Aprovando {{assetSymbol}} para transferência de {{fromNetwork}}",
+      "squidRouterNoPermitSwap": "Transferindo {{assetSymbol}} de {{fromNetwork}} via bridge",
+      "squidRouterNoPermitTransfer": "Transferindo {{assetSymbol}} para conta de processamento",
       "squidRouterPermitExecute": "Autorizando transferência de {{assetSymbol}} de {{fromNetwork}}",
       "squidRouterSwap": "Transferindo {{assetSymbol}} de {{fromNetwork}} para {{toNetwork}}",
       "stellarPayment": "Transferindo {{assetSymbol}} de Stellar --> parceiro local",