Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates production-facing behavior and documentation by disabling EUR (FiatToken.EURC) ramp progression and surfacing a user-facing “EUR ramp unavailable” message, alongside a documentation URL update for KYB deep links.
Changes:
- Update KYB deep-link documentation examples to use a new widget base URL.
- Add localized “EUR ramp unavailable” copy and show an informational banner in the quote submit UI while disabling submission for EUR.
- Add a backend guard in
RampService.registerRampto reject ramps involving EUR (FiatToken.EURC).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/api/pages/13-kyb-deep-link.md | Updates KYB deep-link URL examples to a new widget base URL. |
| apps/frontend/src/translations/pt.json | Adds PT translation for the EUR ramp-unavailable banner. |
| apps/frontend/src/translations/en.json | Adds EN translation for the EUR ramp-unavailable banner. |
| apps/frontend/src/components/QuoteSubmitButtons/index.tsx | Disables submit and shows an info banner when the selected fiat token is EUR. |
| apps/api/src/api/services/ramp/ramp.service.ts | Blocks ramp registration when input/output currency is EUR (FiatToken.EURC). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## URL Parameters | ||
|
|
||
| Append one of these to the widget URL (e.g. `https://widget.vortexfinance.co/en/widget?kyb`): | ||
| Append one of these to the widget URL (e.g. `https://vortexfinance.co/widget?kyb`): |
Comment on lines
+202
to
+207
| if (quote.inputCurrency === FiatToken.EURC || quote.outputCurrency === FiatToken.EURC) { | ||
| throw new APIError({ | ||
| message: "EUR ramps are currently disabled", | ||
| status: httpStatus.BAD_REQUEST | ||
| }); | ||
| } |
| @@ -1,9 +1,39 @@ | |||
| import { describe, expect, it, mock } from "bun:test"; | |||
| import {describe, expect, it, mock} from "bun:test"; | |||
| @@ -1,9 +1,39 @@ | |||
| import { describe, expect, it, mock } from "bun:test"; | |||
| import {describe, expect, it, mock} from "bun:test"; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.