Conversation
Distinct quote error for when a fiat anchor's fee lookup is unavailable, so an anchor outage is no longer collapsed into the generic FailedToCalculateQuote.
Route EUR quote fee lookups through resolveMykobo{Deposit,Withdraw}Fee. On a
/fees outage: if MYKOBO_FEE_FALLBACK_ENABLED, return the configured flat
MYKOBO_FALLBACK_{DEPOSIT,WITHDRAW}_FEE so EUR quotes still render (display
only); otherwise throw MykoboFeeUnavailableError, which QuoteService maps to
AnchorTemporarilyUnavailable (503). Fallback values are validated at boot.
The fallback is display-only and never prices a ramp execution: EUR ramp
registration remains blocked by the existing kill-switch.
Map AnchorTemporarilyUnavailable to a friendly message and add the anchorUnavailable translation (en, pt).
…ering Add the display-only fee fallback and outage error distinction to the Mykobo and fee-integrity specs (behavior note, invariant, threat vector, checklist). Fix the duplicate invariant number in mykobo.md (two #23 -> renumber to #26).
Address PR review: - vars.ts: the fallback comment claimed EUR start 're-checks the live integration'; it does not. Reword to reflect the actual register-time kill-switch and the future need to re-validate live fees when EUR is re-enabled. - mykobo-fee.ts: when the lookup fails with no fallback configured, log the upstream reason (5xx vs unreachable) before throwing, so the actionable cause isn't lost (QuoteService logs only the wrapper message).
Mykobo fee display fallback with distinct outage error
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.