Conversation
Implements milestone 1 of docs/features/contract-tests.md: consumed-contract zod schemas in packages/shared, validated against the fake (PR-blocking) and against the real SquidRouter API (nightly, non-blocking, no credentials). - zod added to shared via the root catalog; frontend now uses the same entry - FakeSquidRouter now emits quoteId, a field production code consumes - Live-half semantics: call errors are inconclusive (warn + skip); only a successful response that violates the schema fails. CONTRACT_EXPECT_LIVE=1 (set by the nightly contracts.yml) fails a run where zero live calls ran. - The live test uses a neutral placeholder address: Squid screens from/to addresses and 403s blocklisted ones (e.g. the well-known hardhat dev key).
Review feedback: gasLimit is BigInt-parsed downstream (normalizeBigIntString in route-transactions, BigInt() in final-settlement-subsidy), so min(1) was too loose. Both consumers accept decimal or 0x-hex integer strings; the schema now enforces exactly that. Verified against the live API (decimal).
Add the external API contract test layer (milestone 1: SquidRouter)
Add Payments page and rename Business nav to Partners
Biome 2 hard-errors on nested root configs. A git worktree created under .claude/worktrees/ contains the repo's biome.json, so any biome run from the main checkout (e.g. the lint-staged pre-commit hook) failed with "Found a nested root configuration" while such a worktree existed. .claude is already gitignored; now biome skips it too.
…trees Exclude .claude worktrees from biome's scanner
Lower the frontend coverage ratchet floors to match current measured coverage (lines 25%, functions 42%); staging had drifted below the old 25.8%/43% floors, turning every PR red. Add dummy VITE_SUPABASE_* vars to the Playwright webServer env so src/config/supabase.ts doesn't throw at import time (loaded eagerly via services/auth). Without them the app white-screens on CI, where the webServer spins up a fresh Vite instead of reusing `bun dev`, failing all 14 e2e journeys. Mirrors the workaround already in vitest.config.ts.
…supabase-env Unblock frontend coverage gate and fix e2e app boot on CI
The BRL offramp corridor scenarios derived a Substrate ephemeral address via @PolkaDot's WASM keyring purely to satisfy the signingAccounts validation — the EVM→BRL route never signs with it. Under Bun the whole @PolkaDot family loads as both CJS and ESM (dual-package hazard), so the WASM bridge exists twice; cryptoWaitReady() initializes one copy while the keyring binds to the other, leaving an uninitialized bridge that intermittently crashed the suite in CI with 'access to a null reference' in ext_bip39_to_mini_secret. Replace the derived address with a static well-known SS58 placeholder (the value is never used to sign), removing the WASM call from these tests entirely. A true CJS/ESM dedupe isn't cleanly expressible under Bun, so this targets the only site that actually crashed.
…wasm-keyring-flake test(api): drop WASM keyring from BRL corridor tests to fix CI flake
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.