K8SPG-1073: Remove restore_command when backups are disabled

[yoav-katz]

CHANGE DESCRIPTION

Problem:
When spec.backups.enabled: false is set, the operator still configures Patroni's restore_command to invoke pgBackRest (pgbackrest --stanza=<name> archive-get %f "%p"), even though no backup repository exists. Any time a replica needs a WAL segment it can't get via streaming replication, Postgres calls this command, which fails because there's no valid stanza/repo — instead of falling back cleanly to "no WAL available from archive."

Cause:
internal/pgbackrest/postgres.go's PostgreSQL() function already neutralizes archive_command when backups are disabled (sets it to a no-op true), but the equivalent handling was missing for restore_command — it was built and added to the Patroni mandatory parameter set unconditionally, with no backupsEnabled check at all.

Solution:
restore_command is no longer set when backups are disabled. Unlike archive_command, it can't simply be pointed at a no-op placeholder like true: Postgres treats a zero exit status from restore_command as "the file was placed at %p," so a placeholder that always succeeds would make Postgres believe WAL recovery succeeded when it didn't, risking a crash or silent gap. Instead, restore_command is omitted entirely in this case, so Postgres relies purely on streaming replication and local WAL. An explicit user override of restore_command via spec.patroni.dynamicConfiguration is still respected regardless of backups.enabled, since that reflects an intentional choice by the user.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported PG version?
• Does the change support oldest and newest supported Kubernetes version?

[Copilot]

Pull request overview

This PR updates pgBackRest-related PostgreSQL parameter generation so Patroni does not configure restore_command when backups are disabled, preventing Postgres from attempting (and failing) WAL archive restores when no repository exists.

Changes:

• Omit restore_command from Patroni mandatory parameters when backups are disabled, unless the user explicitly overrides it.
• Add unit test coverage for the “backups disabled” behavior, including override and standby-repo scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/pgbackrest/postgres.go	Conditionally adds restore_command only when backups are enabled or user-overridden (standby repo still forces it).
internal/pgbackrest/postgres_test.go	Adds a test case ensuring restore_command is omitted when backups are disabled, while preserving override and standby behavior.

[egegunes]

@yoav-katz monitoring tests are failing repeatedly but I doubt it's related to your changes. we'll check.

[yoav-katz]

the same tests are failing in another PR I opened #1647
the cause of the failure -
error creating gce static IP address: googleapi: Error 403: QUOTA_EXCEEDED - Quota

[JNKPercona]

Test Name	Result	Time
backup-enable-disable	passed	00:12:22
builtin-extensions	passed	00:06:30
cert-manager-tls	passed	00:11:19
custom-envs	passed	00:19:15
custom-tls	passed	00:06:15
database-init-sql	passed	00:02:42
demand-backup	passed	00:25:16
demand-backup-offline-snapshot	passed	00:13:52
dynamic-configuration	passed	00:03:11
finalizers	passed	00:03:39
init-deploy	passed	00:03:23
huge-pages	passed	00:03:15
major-upgrade-14-to-15	passed	00:11:44
major-upgrade-15-to-16	passed	00:10:37
major-upgrade-16-to-17	passed	00:11:58
major-upgrade-17-to-18	passed	00:10:42
ldap	passed	00:03:55
ldap-tls	passed	00:06:13
monitoring	passed	00:08:41
monitoring-pmm3	passed	00:10:36
one-pod	passed	00:06:00
operator-self-healing	passed	00:11:02
pitr	passed	00:13:28
scaling	passed	00:05:48
scheduled-backup	passed	00:28:57
self-healing	passed	00:09:15
sidecars	passed	00:03:01
standby-pgbackrest	passed	00:17:39
standby-streaming	passed	00:13:50
start-from-backup	passed	00:11:38
tablespaces	passed	00:07:01
telemetry-transfer	passed	00:04:44
upgrade-consistency	passed	00:07:02
upgrade-minor	passed	00:07:53
users	passed	00:05:16
migration-from-crunchy-standby	passed	00:19:11
migration-from-crunchy-pv	passed	00:08:29
migration-from-crunchy-backup-restore	passed	00:18:15

Summary	Value
Tests Run	38/38
Job Duration	02:08:22
Total Test Time	06:24:16

commit: 21b52c7
image: perconalab/percona-postgresql-operator:PR-1673-21b52c769

[hors]

@yoav-katz thank you for the contribution.