K8SPG-1045: add .spec.tls.certManagementPolicy field#1679
Open
pooknull wants to merge 12 commits into
Open
Conversation
pooknull
marked this pull request as ready for review
July 15, 2026 14:12
pooknull
requested review from
DhruthiKV,
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
valmiranogueira
as code owners
July 15, 2026 14:12
egegunes
reviewed
Jul 16, 2026
| ); err != nil { | ||
| return nil, errors.Wrapf(err, "get user-provided instance TLS secret %s", existing.Name) | ||
| } | ||
| return existing, nil |
Contributor
There was a problem hiding this comment.
we're returning a nil *corev1.Secret with a nil error. this is unexpected for caller. can we improve if possible or at least comment in function's godoc
nmarukovich
reviewed
Jul 16, 2026
| _, hasCluster := obj.GetLabels()[naming.LabelCluster] | ||
| return hasCluster | ||
| }))). | ||
| Watches(&corev1.Pod{}, r.watchPods()). |
Contributor
There was a problem hiding this comment.
What would be if I create secret manually? As I understand we don't have labels in secret in this case.
Contributor
Author
There was a problem hiding this comment.
We are going to expect user to set this cluster label: #1679 (comment)
Collaborator
|
@pooknull please fix conflicts |
egegunes
reviewed
Jul 21, 2026
Comment on lines
+39
to
+50
| clusters := &v1beta1.PostgresClusterList{} | ||
| if err := r.Client.List(ctx, clusters, client.InNamespace(obj.GetNamespace())); err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| requests := make([]reconcile.Request, 0, len(clusters.Items)) | ||
| for i := range clusters.Items { | ||
| requests = append(requests, reconcile.Request{ | ||
| NamespacedName: client.ObjectKeyFromObject(&clusters.Items[i]), | ||
| }) | ||
| } | ||
| return requests |
Contributor
There was a problem hiding this comment.
are we sure that we want to do this? i'd force user to add cluster label to the secret instead of blindly triggering reconcile
Contributor
Author
There was a problem hiding this comment.
I agree with you. I have reverted this change: 1c0bbf6
This reverts commit 3e8b007.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-1045
DESCRIPTION
This PR adds
.spec.tls.certManagementPolicywhich controls how TLS secrets are managed. The following values are supported:auto- the operator creates and maintains TLS secrets. This is the default.userProvidedOnly- the operator never generates or modifies TLS secrets. Reconciliation pauses until every required secret is provided by the user.When secrets are missing (when
userProvidedOnlyis used), the cluster reports:The
TLSSecretsReadymessage lists the missing secret names.Once these secrets are present, the operator creates the instance
StatefulSetso its generated name can be seen by the user.After that, user should create corresponding
<statefulset-name>-certssecret.User's secrets should contain
postgres-operator.crunchydata.com/cluster: <cluster-name>label to trigger reconcileCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability