Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

PMM-9377 upgrade to grpc-gateway v2 - #1056

Merged
idoqo merged 11 commits into
mainfrom
grpc-gateway-v2
Jun 7, 2022
Merged

PMM-9377 upgrade to grpc-gateway v2#1056
idoqo merged 11 commits into
mainfrom
grpc-gateway-v2

Conversation

@idoqo

@idoqo idoqo commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

PMM-9377

grpc-gateway v2 upgrade that uses a custom error handler instead of a fork.

Build: SUBMODULES-2419

@codecov

codecov Bot commented Apr 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1056 (f142bfe) into main (09daeb9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head f142bfe differs from pull request most recent head 2934d64. Consider uploading reports for the commit 2934d64 to get more accurate results

@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
- Coverage   48.69%   48.68%   -0.02%     
==========================================
  Files         181      181              
  Lines       21258    21263       +5     
==========================================
  Hits        10351    10351              
- Misses       9769     9774       +5     
  Partials     1138     1138              
Flag Coverage Δ
all 48.33% <0.00%> (-0.02%) ⬇️
cover 48.80% <0.00%> (-0.02%) ⬇️
crosscover 48.68% <0.00%> (-0.02%) ⬇️
update 12.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
services/converters.go 74.53% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09daeb9...2934d64. Read the comment docs.

@idoqo
idoqo force-pushed the grpc-gateway-v2 branch from f984e89 to 52c4821 Compare May 3, 2022 22:14
@idoqo
idoqo marked this pull request as ready for review May 18, 2022 06:58
@idoqo idoqo changed the title upgrade to grpc-gateway v2 PMM-9377 upgrade to grpc-gateway v2 Jun 1, 2022
@idoqo
idoqo requested review from ademidoff and palash25 June 1, 2022 07:51
Comment thread api-tests/helpers.go
@idoqo
idoqo merged commit 5356c5b into main Jun 7, 2022
@idoqo
idoqo deleted the grpc-gateway-v2 branch June 7, 2022 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants