PMM-15216: install pnpm in rpmbuild images for UI feature builds#5654
Draft
fabio-silva wants to merge 1 commit into
Draft
PMM-15216: install pnpm in rpmbuild images for UI feature builds#5654fabio-silva wants to merge 1 commit into
fabio-silva wants to merge 1 commit into
Conversation
Feature builds fail with `pnpm: No such file or directory` because public.ecr.aws/e7j3v3n0/rpmbuild:3 ships nodejs+yarn only. Install pnpm@11.1.3 in the rpmbuild Dockerfiles, and add an npm global fallback in ui/Makefile so FBs work before the image is republished. Co-authored-by: Fábio Silva <fabio-silva@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PMM-15216 #5654 +/- ##
============================================
Coverage ? 44.10%
============================================
Files ? 416
Lines ? 43067
Branches ? 0
============================================
Hits ? 18996
Misses ? 22192
Partials ? 1879
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15216
Feature build: Percona-Lab/pmm-submodules#4474
Summary
Jenkins feature builds for the SEP frontend integration fail with
pnpm: No such file or directorybecausepublic.ecr.aws/e7j3v3n0/rpmbuild:3ships nodejs + yarn only.This PR:
pnpm@11.1.3(matchesui/package.jsonpackageManager) inbuild/docker/rpmbuild/Dockerfile.{el8,el9,hetzner-el9}ui/Makefilesetup: keep corepack enable, then fall back tosudo npm install -g pnpm@11.1.3so FBs work beforerpmbuild:3is republishedSuperseded: the same fix was pushed to
PMM-15216(03d5f0212), and that branch has since been updated withmain(c2c84db17). This PR is empty/redundant vs its base; safe to close.Related: Percona-Lab/pmm-submodules#4474, percona/pmm#5653