Skip to content

Impact analysis changes for version 8.3.4-1#1151

Open
rasika-chivate wants to merge 22 commits into
8.3from
Impact-analysis-changes-for-version-8.3.4-1
Open

Impact analysis changes for version 8.3.4-1#1151
rasika-chivate wants to merge 22 commits into
8.3from
Impact-analysis-changes-for-version-8.3.4-1

Conversation

@rasika-chivate

Copy link
Copy Markdown
Collaborator

As we are upgrading to version 8.3, we need to make changes to the version in the upgrade, installation, and other related files.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation set to reflect the upgrade to Percona Server for MongoDB 8.3 (8.3.4-1), ensuring install/upgrade instructions, examples, and version references match the new release.

Changes:

  • Bumped version references in telemetry examples, upgrade guides, and comparison/quickstart pages from 8.0.x to 8.3.4 / 8.3.
  • Updated installation instructions across package managers, tarball URLs, Docker examples, and Percona repo channel names (e.g., psmdb-83).
  • Refreshed source-build examples (branches, artifacts, tools tags) for the 8.3.4-1 release.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/telemetry.md Updates telemetry payload examples to report pillar_version as 8.3.4.
docs/install/upgrade-from-mongodb.md Updates package-version examples for MongoDB CE → PSMDB upgrade flow.
docs/install/upgrade-from-80.md Updates the in-place upgrade doc from 8.0 → 8.3 (links, repo channel, narrative).
docs/install/tarball.md Updates tarball download URLs from the 8.0 path to the 8.3 path.
docs/install/source.md Updates branch/version examples and artifact names for building 8.3.4-1.
docs/install/index.md Updates Quickstart intro to position PSMDB as a drop-in for MongoDB 8.3 CE.
docs/install/docker.md Updates Docker examples and image tags from 8.0 to 8.3.
docs/install/apt.md Updates THP guidance wording to reference 8.3.
docs/install/amazon-linux.md Updates repository/channel example from psmdb-80 to psmdb-83.
docs/horizon-setup.md Updates the Horizon setup Docker image tag to 8.3.
docs/comparison.md Updates comparison intro to reflect MongoDB CE 8.3 baseline.
Comments suppressed due to low confidence (4)

docs/install/upgrade-from-80.md:100

  • The upgrade text says to enable 8.3 features, but the FCV command still sets setFeatureCompatibilityVersion to "8.0", which would not enable 8.3 behavior.
    docs/install/source.md:280
  • This command line concatenates --psm_ver and --psm_release (missing space), and also uses --mongo_tools_tag=100.7.0 while the rest of the 8.3.4 examples use 100.17.0. This inconsistency is likely to produce the wrong tools version (or a failed build).
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.7.0 --build_src_rpm=1

docs/install/source.md:306

  • This command line concatenates --psm_ver and --psm_release without a space, which will be parsed as a single argument.
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.17.0 --build_deb=1

docs/install/upgrade-from-mongodb.md:127

  • These yum remove examples use .el8 package names while the installed-packages sample output above is .el9. The example should use consistent distro suffixes.
         mongodb-org-server-8.3.4-1.el8.x86_64
         mongodb-org-mongos-8.3.4-1.el8.x86_64
         mongodb-org-tools-8.3.4-1.el8.x86_64

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/install/source.md Outdated
Comment thread docs/install/upgrade-from-mongodb.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (4)

docs/install/upgrade-from-80.md:88

  • In the RHEL/Rocky section, step 4 installs 8.3 packages but step 2 still enables the 8.0 repository (psmdb-80). This makes the upgrade instructions inconsistent and may pull the wrong major version.
    docs/install/source.md:281
  • The --psm_ver and --psm_release flags are concatenated (--psm_ver=8.3.4--psm_release=1), which will be parsed as a single invalid argument. Also, this section still uses an older --mongo_tools_tag value than the rest of the 8.3.4 examples in this file.
        bash -x ./psmdb_builder.sh --builddir=/tmp/psmdb/test --repo=https://github.com/percona/percona-server-mongodb.git \
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.7.0 --build_src_rpm=1
        '

docs/install/source.md:307

  • Same issue here: --psm_ver and --psm_release are concatenated, which will make the example command fail when copied.
        bash -x ./psmdb_builder.sh --builddir=/tmp/psmdb/test --repo=https://github.com/percona/percona-server-mongodb.git \
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.17.0 --build_deb=1
        '

docs/install/upgrade-from-80.md:100

  • The command to enable 8.3 features still sets the Feature Compatibility Version to 8.0. That conflicts with the preceding text and would leave the cluster in 8.0 FCV.

Comment thread docs/install/upgrade-from-mongodb.md Outdated
Comment thread docs/install/source.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (7)

docs/install/upgrade-from-mongodb.md:123

  • The yum remove snippet is not copy/paste safe: only the first line uses a continuation (\), so the remaining package lines will be executed as separate commands. Also, the last three package NEVRAs use el8 while the sample output above is el9, which is inconsistent.
         ```bash
         sudo yum remove \
         mongodb-org-shell-8.3.4-1.el9.x86_64 \
         mongodb-org-database-8.3.4-1.el9.x86_64 \
         mongodb-org-8.3.4-1.el9.x86_64 \

docs/install/source.md:280

  • This build-script example concatenates two flags (--psm_ver and --psm_release) and uses a different --mongo_tools_tag than the other 8.3.4-1 examples in this doc, which will break the command as written.
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.7.0 --build_src_rpm=1

docs/install/source.md:306

  • This command concatenates --psm_ver and --psm_release into a single flag value (8.3.4--psm_release=1), which will cause the script to receive an invalid --psm_ver value.
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.17.0 --build_deb=1

docs/install/source.md:293

  • This ls -la sample output line is missing the leading file-type character (e.g., -rw-r--r--), which makes it inconsistent with the other ls examples on this page.
            rw-r--r--. 1 root root 90398894 Jul  1 11:45 percona-server-mongodb-8.3.4-1.generic.src.rpm

docs/install/upgrade-from-80.md:85

  • The RHEL/DNF/YUM path still enables the psmdb-80 repo while the rest of the page describes upgrading to 8.3. This is inconsistent and will direct users to the wrong repository.

This issue also appears on line 97 of the same file.
docs/install/upgrade-from-80.md:101

  • The text says to enable 8.3 features after the upgrade, but the example sets setFeatureCompatibilityVersion to 8.0, which would keep the cluster on 8.0 FCV.
    docs/install/tarball.md:107
  • The trailing \ escapes the newline, so these two curl commands will be concatenated into one line when copied into a shell (and fail). They should be separate commands (or use && \ if you want an explicit continuation).
        ```bash
        curl -O https://downloads.percona.com/downloads/percona-server-mongodb-8.3/percona-server-mongodb-{{release}}/binary/tarball/percona-server-mongodb-{{release}}-x86_64.jammy.tar.gz\
        curl -O https://downloads.percona.com/downloads/percona-server-mongodb-8.3/percona-server-mongodb-{{release}}/binary/tarball/percona-mongodb-mongosh-{{mongosh}}-x86_64.tar.gz

Comment thread docs/install/tarball.md Outdated
Comment thread snippets/al-compatibility.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (6)

docs/install/upgrade-from-80.md:100

  • This command claims to enable 8.3 features but still sets the Feature Compatibility Version to "8.0". The FCV value should match the target major/minor version (8.3) to actually enable 8.3 features.
    docs/install/tarball.md:106
  • This curl line ends with a trailing \, which escapes the newline and will concatenate the next curl command, making the snippet fail when copy/pasted. Since each curl is on its own line, the trailing backslash should be removed.
        curl -O https://downloads.percona.com/downloads/percona-server-mongodb-8.3/percona-server-mongodb-{{release}}/binary/tarball/percona-server-mongodb-{{release}}-x86_64.jammy.tar.gz\

docs/install/source.md:280

  • There is a missing space between --psm_ver and --psm_release, which will turn --psm_release into part of the --psm_ver value and likely break the command. Also, this RPM source-package example uses --mongo_tools_tag=100.7.0 while the other 8.3.4-1 examples in this document use 100.17.0.
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.7.0 --build_src_rpm=1

docs/install/source.md:306

  • Missing space between --psm_ver and --psm_release makes the command invalid (the flags get concatenated).
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.17.0 --build_deb=1

docs/install/source.md:293

  • This ls -la sample output line is missing the leading file-type character (it should start with -rw...). As written (rw-r--r--.) it isn't valid ls output.
            rw-r--r--. 1 root root 90398894 Jul  1 11:45 percona-server-mongodb-8.3.4-1.generic.src.rpm

docs/install/upgrade-from-80.md:89

  • These RHEL instructions install 8.3 packages, but the earlier repo-enable step in this section still enables psmdb-80 / refers to “8.0”. That mismatch can lead to installing the wrong major series depending on repo state. The repo enable step should be updated to psmdb-83 and mention 8.3.

This issue also appears on line 100 of the same file.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (6)

docs/install/upgrade-from-80.md:85

  • In the RHEL upgrade section, the repository enable step still references PSMDB 8.0 (psmdb-80). This conflicts with the rest of the doc targeting 8.3 and will point users at the wrong repo.

This issue also appears on line 97 of the same file.
docs/install/tarball.md:106

  • The trailing \ makes these two curl commands run as a single continued line, which breaks copy/paste execution in a shell. Use two separate commands (no line continuation) or join with &&.
        curl -O https://downloads.percona.com/downloads/percona-server-mongodb-8.3/percona-server-mongodb-{{release}}/binary/tarball/percona-server-mongodb-{{release}}-x86_64.jammy.tar.gz\

docs/install/source.md:280

  • This example command is missing a space between --psm_ver and --psm_release, so it becomes a single invalid argument (--psm_ver=8.3.4--psm_release=1).
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.7.0 --build_src_rpm=1

docs/install/source.md:306

  • This example command is missing a space between --psm_ver and --psm_release, so it becomes a single invalid argument (--psm_ver=8.3.4--psm_release=1).
        --branch=release-8.3.4-1 --psm_ver=8.3.4--psm_release=1 --mongo_tools_tag=100.17.0 --build_deb=1

docs/install/upgrade-from-80.md:12

  • This file’s "Considerations" section was significantly reduced (e.g., THP/KMIP/Amazon Linux notes and general upgrade guidance were removed) while the PR description says the goal is primarily version updates. If the removals are intentional, the PR description should reflect that; otherwise, the removed guidance should be restored and updated for 8.3.
    docs/install/upgrade-from-80.md:97
  • The text says to enable 8.3 features after the upgrade, but the setFeatureCompatibilityVersion example still sets FCV to 8.0. That would leave the deployment in the old feature set.

@rasika-chivate
rasika-chivate requested a review from vorsel July 23, 2026 16:04
@rasika-chivate
rasika-chivate marked this pull request as ready for review July 23, 2026 16:04
mongodb-org-tools-8.0.1-1.el9.x86_64
mongodb-org-shell-8.3.4-1.el9.x86_64
mongodb-org-database-8.3.4-1.el9.x86_64
mongodb-org-8.3.4-1.el9.x86_64

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra spaces in from of the file names

|------------------------------------|---------------------------|
| 8.0.4-2 | 2023.6.x and older |
| 8.0.8-3 | 2023.7.x and newer |
| 8.3.4-1 | 2023.11.x and older |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023.11.x and older

Should be "newer", cause the packages built on 2023.11 will not work on 2023.4 at least due to glibc version mismatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants