Improve the list guidelines and pull request guidelines (pull request template)#58
Open
yishangupenn wants to merge 3 commits into
Open
Improve the list guidelines and pull request guidelines (pull request template)#58yishangupenn wants to merge 3 commits into
yishangupenn wants to merge 3 commits into
Conversation
1. Categorize the guidelines into sections within two files. 2. Simplify the instructions and description. 3. Remove the redundant information.
…pull request guidelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I open the pull request
I read through the pull request template and other files before I started to create my list Awesome Technical Writing Learning. I stayed confused during my reading:
What I did
What is in question
There are several sentences in the pull request template I maybe didn't understand correctly. I added a comment for each of them, like this:
If you like the style of the improved guidelines, please feel free to review and comment on how to make it better. Thanks!