fix: correct model reference in Node.BeforeUpdate hook#115
Open
Ember-Moth wants to merge 1 commit intoperfect-panel:developfrom
Open
fix: correct model reference in Node.BeforeUpdate hook#115Ember-Moth wants to merge 1 commit intoperfect-panel:developfrom
Ember-Moth wants to merge 1 commit intoperfect-panel:developfrom
Conversation
The BeforeUpdate method was incorrectly using `Model(&Server{})` instead
of `Model(&Node{})` when checking for duplicate sort values and getting
the maximum sort value. This is a copy-paste error from the Server
model.
- Change Model(&Server{}) → Model(&Node{}) on line 49
- Change Model(&Server{}) → Model(&Node{}) on line 61
- Fix log tag from [Server] → [Node] on line 56 for consistency
This ensures that sort order maintenance works correctly for the nodes
table, preventing duplicate sort values and data inconsistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BeforeUpdate method was incorrectly using
Model(&Server{})instead ofModel(&Node{})when checking for duplicate sort values and getting the maximum sort value. This is a copy-paste error from the Server model.This ensures that sort order maintenance works correctly for the nodes table, preventing duplicate sort values and data inconsistency.