fix binaries create bundle-creation convenience codepath#235
Merged
lee-reinhardt merged 1 commit intomainfrom Feb 13, 2026
Merged
fix binaries create bundle-creation convenience codepath#235lee-reinhardt merged 1 commit intomainfrom
binaries create bundle-creation convenience codepath#235lee-reinhardt merged 1 commit intomainfrom
Conversation
lee-reinhardt
force-pushed
the
lee-eng-1279
branch
from
35b270c to
9b7f2d7
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes the binaries create “fetch-or-create bundle” convenience path by constructing version-correct bundle creation parameters for Peridio API v1 vs v2.
Changes:
- Split bundle param construction into
create_bundle_params_v1andcreate_bundle_params_v2. - Fix API v2 bundle creation to use binary PRNs (instead of artifact version PRNs).
- Add unit tests covering both v1/v2 param mapping behavior; bump crate version to
1.7.1.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/api/binaries.rs |
Corrects bundle-create payload selection by API version and adds unit tests for v1/v2 param construction. |
Cargo.toml |
Bumps CLI version to 1.7.1. |
Cargo.lock |
Updates lockfile entry to match the new crate version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jasontwong
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.