[BUGFIX] prometheus: check for length of filters before adding braces#611
Open
coleenquadros wants to merge 3 commits intoperses:mainfrom
Open
[BUGFIX] prometheus: check for length of filters before adding braces#611coleenquadros wants to merge 3 commits intoperses:mainfrom
coleenquadros wants to merge 3 commits intoperses:mainfrom
Conversation
Contributor
|
Hello @coleenquadros can you add some context for this change in PR description please? Also the second commit doesn't seem related at all |
Contributor
|
Could you move the changes related to the PieChart Go SDK to a separate PR please? |
f319946 to
d875a36
Compare
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
This reverts commit cd6e479. Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
d875a36 to
954f40f
Compare
Contributor
|
Sorry I don't understand the issue you are trying to fix. The fact Thus please precise
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When metadata is used as a label matcher, it gets interpreted as a timeseries and does not return data since we dont add label matchers when defining the variable and forces the braces {} in the query.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.