Skip to content

[BUGFIX] PieChart: fix missing Calculation in Go SDK #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntoineThebaud merged 1 commit into from
Mar 26, 2026
+12 −1
Merged

[BUGFIX] PieChart: fix missing Calculation in Go SDK #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions piechart/sdk/go/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ package pie

import "github.com/perses/perses/go-sdk/common"

func Calculation(calculation common.Calculation) Option {
return func(builder *Builder) error {
builder.Calculation = calculation
return nil
}
}

func WithLegend(legend Legend) Option {
return func(builder *Builder) error {
builder.Legend = &legend
Expand Down
6 changes: 5 additions & 1 deletion piechart/sdk/go/pie.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,11 @@ func create(options ...Option) (Builder, error) {
PluginSpec: PluginSpec{},
}

for _, opt := range options {
defaults := []Option{
Calculation(common.LastCalculation),
}

for _, opt := range append(defaults, options...) {
if err := opt(builder); err != nil {
return *builder, err
}
Expand Down
Loading